#15164: NSym (NCSF): Verschiebung, doc improvements, meet and join of 
compositions
-------------------------------------------------+-------------------------
       Reporter:  darij                          |        Owner:
           Type:  enhancement                    |       Status:
       Priority:  major                          |  needs_review
      Component:  combinatorics                  |    Milestone:  sage-5.12
       Keywords:  sage-combinat, NSym, NCSF,     |   Resolution:
  symmetric functions                            |    Merged in:
        Authors:  Darij Grinberg                 |    Reviewers:  Travis
Report Upstream:  N/A                            |  Scrimshaw
         Branch:                                 |  Work issues:
   Dependencies:  #14775, #14981, #15094,        |       Commit:
  #15122                                         |     Stopgaps:
-------------------------------------------------+-------------------------

Comment (by darij):

 Hi Travis,

 thanks for the review -- there's only a few things I'd like you to fix.

 1) The line
 {{{
 Let us check the defining property in degree `4`::
 }}}
 is not good. While the duality between internal coproduct and internal
 product is currently the only thing explaining the internal product in the
 docstring, it is not the usual definition of the internal product, and
 should not be called its "defining property". Just say "the duality
 between internal product and internal coproduct" instead.

 2)
 {{{
                 `i_1`, `i_2`, \ldots, `i_k` are divisible by `n`, and to
 `0`
 }}}
 The \ldots here are outside of mathmode; do they work?

 3)
 {{{
                 integer `r` with `n \mid r`, it satisfes
 }}}
 Please put back the \nmid that you replaced by \mid here.

 I won't come home until in the evening, and I won't have much time by
 then, which is why I'm not doing these changes myself. Sorry. Once you're
 done, please set this to positive_review.

--
Ticket URL: <http://trac.sagemath.org/ticket/15164#comment:10>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica, 
and MATLAB

-- 
You received this message because you are subscribed to the Google Groups 
"sage-trac" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to [email protected].
To post to this group, send email to [email protected].
Visit this group at http://groups.google.com/group/sage-trac.
For more options, visit https://groups.google.com/groups/opt_out.

Reply via email to