#9290: Implement Coxeter groups in their geometric representation
------------------------------------+-----------------------------
       Reporter:  nthiery           |        Owner:  sage-combinat
           Type:  enhancement       |       Status:  needs_review
       Priority:  major             |    Milestone:  sage-5.12
      Component:  combinatorics     |   Resolution:
       Keywords:  coxeter           |    Merged in:
        Authors:  Travis Scrimshaw  |    Reviewers:
Report Upstream:  N/A               |  Work issues:
         Branch:                    |       Commit:
   Dependencies:  #15204            |     Stopgaps:
------------------------------------+-----------------------------

Comment (by tscrim):

 Hey Frederic,

 Replying to [comment:11 chapoton]:
 > "assert implementation" : I think this use of assert to check input is
 not encouraged

 This was a hold-over from the previous implementation, but this is
 definitely a good time to get rid of it. Fixed.

 > "lazy_import('sage.groups.raag', 'RightAngledArtinGroup')" : has this
 something to do in this ticket ?

 Because I didn't split it cleanly with #15137. Fixed.

 > What are the changes "sage/groups/matrix_gps/finitely_generated.py" for
 ?

 I need to pass the `CoxeterGroups` category up during the initialization,
 so I had to make those changes.

 Thanks for catching that,[[BR]]
 Travis

--
Ticket URL: <http://trac.sagemath.org/ticket/9290#comment:12>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica, 
and MATLAB

-- 
You received this message because you are subscribed to the Google Groups 
"sage-trac" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to [email protected].
To post to this group, send email to [email protected].
Visit this group at http://groups.google.com/group/sage-trac.
For more options, visit https://groups.google.com/groups/opt_out.

Reply via email to