#14888: Make FiniteField_pari_ffelt the default for generic finite fields
-------------------------------------+-------------------------------------
Reporter: pbruin | Owner: cpernet
Type: enhancement | Status: needs_review
Priority: major | Milestone: sage-5.13
Component: finite rings | Resolution:
Keywords: FiniteField | Merged in:
performance | Reviewers: Jean-Pierre Flori,
Authors: Peter Bruin, | Jeroen Demeyer, Peter Bruin
Jeroen Demeyer | Work issues:
Report Upstream: N/A | Commit:
Branch: | Stopgaps:
Dependencies: #12142, #15124, |
#15125 |
-------------------------------------+-------------------------------------
Changes (by pbruin):
* reviewer: Jean-Pierre Flori, Jeroen Demeyer => Jean-Pierre Flori, Jeroen
Demeyer, Peter Bruin
Comment:
Replying to [comment:39 jdemeyer]:
> Got it! The following line is no good:
> {{{
> x_GEN = (<pari_gen>pari(x)).g
> }}}
> Python can destroy the object `pari(x)` because there are no references
to it (the pointer `x_GEN` doesn't count as a reference for Python's
garbage collecting).
Beautiful! I checked the C code generated by Cython and it does indeed
decrease the reference count of this temporary object too early.
I have never been able to reproduce the bug, but I'm convinced that you
nailed the problem. I'll run doctests and then give this a positive
review.
--
Ticket URL: <http://trac.sagemath.org/ticket/14888#comment:42>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica,
and MATLAB
--
You received this message because you are subscribed to the Google Groups
"sage-trac" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
To post to this group, send email to [email protected].
Visit this group at http://groups.google.com/group/sage-trac.
For more options, visit https://groups.google.com/groups/opt_out.
