#10132: Parametrization of (metric) surfaces in 3D euclidean space
-------------------------------------------------+-------------------------
Reporter: mikarm | Owner: mikarm
Type: enhancement | Status:
Priority: major | positive_review
Component: geometry | Milestone: sage-5.13
Keywords: differential geometry, | Resolution:
parametrized surface | Merged in:
Authors: Mikhail Malakhaltsev, Joris | Reviewers:
Vankerschaver | vdelecroix
Report Upstream: N/A | Work issues:
Branch: | Commit:
Dependencies: #11549, #12737 | Stopgaps:
-------------------------------------------------+-------------------------
Changes (by vdelecroix):
* status: needs_review => positive_review
Comment:
Hi,
Sorry for the long time between the reviews. I think that the patch is
ready to go and has wait too much. The patch applies on 5.12.rc0 and test
succeded.
I just leave further remarks for next improvement
1) I found that you use way too much cached_method (12 occurrences). Their
usage is expensive precisely because they cache the result. It should be
use only in time critical part of the code. I would suppress it from:
rotation, _create_geodesic_ode_system.
2) the code here is in its most part compatible with sage-manifolds
(#14865). There should be a merge at some point. Sage manifolds allows to
have multiple charts and hence to have more embedded surfaces!
--
Ticket URL: <http://trac.sagemath.org/ticket/10132#comment:74>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica,
and MATLAB
--
You received this message because you are subscribed to the Google Groups
"sage-trac" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
To post to this group, send email to [email protected].
Visit this group at http://groups.google.com/group/sage-trac.
For more options, visit https://groups.google.com/groups/opt_out.
