#15283: Rowmotion and Panyushev orbits: iterators for orbits and better doc
-------------------------------------------------+-------------------------
Reporter: darij | Owner:
Type: enhancement | Status:
Priority: major | needs_work
Component: combinatorics | Milestone: sage-5.13
Keywords: posets, rowmotion, sage- | Resolution:
combinat, panyushev, order-ideals, categories | Merged in:
Authors: Darij Grinberg | Reviewers:
Report Upstream: N/A | Work issues:
Branch: | Commit:
Dependencies: | Stopgaps:
-------------------------------------------------+-------------------------
Changes (by ncohen):
* status: needs_review => needs_work
Comment:
Helloooooooooooooooooooooo !!
I read this patch and even though I am not from the field I feel that it
could get in. I only have some small remarks to make :
* Could the Poset class need a `.is_antichain(vertices=[...])` method to
check if this set of vertices induces an antichain ? You have a
`.is_chain()` method, but it does not take any argument.
* {{{``panyushev_complement``}}} should be
{{{:meth:`panyushev_complement`}}}
* isn't "generated by the antichain `antichain`, represented by its
generating antichain" slightly redundant ? `:-P`
* With my first reading, I understood ``toggling_orbit_iter`` would take a
set and a list of points, and return the toggle of the set with the first
point, then this new set toggled with the second point, then this new set
with the third point, ... I does not make much sense it is true,
especially with ``stop=True``, but if you think somebody from the field
could make the same mistake perhaps it could be made clearer `:-)`
Nathann
--
Ticket URL: <http://trac.sagemath.org/ticket/15283#comment:2>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica,
and MATLAB
--
You received this message because you are subscribed to the Google Groups
"sage-trac" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
To post to this group, send email to [email protected].
Visit this group at http://groups.google.com/group/sage-trac.
For more options, visit https://groups.google.com/groups/opt_out.
