#13394: Write a WeakValueDictionary with safer key removal
-------------------------------------+-------------------------------------
Reporter: nbruin | Owner: rlm
Type: enhancement | Status: needs_review
Priority: major | Milestone: sage-5.13
Component: memleak | Resolution:
Keywords: | Merged in:
Authors: Simon King | Reviewers:
Report Upstream: None of the above | Work issues:
- read trac for reasoning. | Commit:
Branch: | fab0ed4112b9f798e2690f4c885b57cd711ea698
u/SimonKing/ticket/13394 | Stopgaps:
Dependencies: |
-------------------------------------+-------------------------------------
Comment (by nbruin):
Replying to [comment:48 SimonKing]:
> PS: We don't even need a hash collision with the implicitly inserted
item to fool Python's dicts.
You haven't implemented equality in the way you think:
{{{
sage: k1=Key()
sage: k2=Key()
sage: k1 is k2, k1==k2
inserting 5
(False, True)
}}}
so python's dict acts consistently with the results of "==" as it should.
(if you implement `__cmp__` then `0` means equal, which is a falsey value.
If you implement this with `__eq__` instead, you see that `dict` works
properly).
--
Ticket URL: <http://trac.sagemath.org/ticket/13394#comment:51>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica,
and MATLAB
--
You received this message because you are subscribed to the Google Groups
"sage-trac" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
To post to this group, send email to [email protected].
Visit this group at http://groups.google.com/group/sage-trac.
For more options, visit https://groups.google.com/groups/opt_out.
