#13394: Write a WeakValueDictionary with safer key removal
-------------------------------------+-------------------------------------
Reporter: nbruin | Owner: rlm
Type: enhancement | Status: needs_review
Priority: major | Milestone: sage-5.13
Component: memleak | Resolution:
Keywords: | Merged in:
Authors: Simon King, Nils | Reviewers: Simon King
Bruin | Work issues:
Report Upstream: None of the above | Commit:
- read trac for reasoning. | 851cc9522dde332561101f1c84182a0a84b8eed4
Branch: | Stopgaps:
u/SimonKing/ticket/13394 |
Dependencies: |
-------------------------------------+-------------------------------------
Comment (by nbruin):
Replying to [comment:67 SimonKing]:
> Nils, could you please try to download the commits that I have pushed?
Your file reverts changes that I already did (and I think ''should'' be
done).
I did. My changes were based on:
{{{
commit 851cc9522dde332561101f1c84182a0a84b8eed4
Author: Simon King <[email protected]>
Date: Thu Oct 31 14:37:21 2013 +0100
Avoid some pointer casts in WeakValueDict callbacks
}}}
I reverted those things necessary to have `del_dictitem_by_exact_value` in
`cpdef` form. If you prefer to have a `cdef _del_dictitem_by_exact_value`
version with a `def del_dictitem_by_exact_value` that's fine with me. For
doctesting, I think we want to expose the routine on python level. It
should be easy to prove that the routine works as advertised/show
problems.
--
Ticket URL: <http://trac.sagemath.org/ticket/13394#comment:69>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica,
and MATLAB
--
You received this message because you are subscribed to the Google Groups
"sage-trac" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
To post to this group, send email to [email protected].
Visit this group at http://groups.google.com/group/sage-trac.
For more options, visit https://groups.google.com/groups/opt_out.
