#14789: Implement hyperplane arrangements
-------------------------------------+-------------------------------------
Reporter: kcrisman | Owner: sage-combinat
Type: enhancement | Status: needs_review
Priority: major | Milestone: sage-5.13
Component: combinatorics | Resolution:
Keywords: | Merged in:
Authors: David Perkinson, | Reviewers: Travis Scrimshaw
Volker Braun | Work issues:
Report Upstream: N/A | Commit:
Branch: | 7a7c6aca580a7fc1481d60f8deb37129aa2b90f8
public/geometry/14789-hyperplane_arrangements| Stopgaps:
Dependencies: |
-------------------------------------+-------------------------------------
Changes (by {'newvalue': u'David Perkinson, Volker Braun', 'oldvalue':
u'dperkinson, vbraun'}):
* commit: 42b1aa531d73ec9fe94f5acd7c50ad885164aeb5 =>
7a7c6aca580a7fc1481d60f8deb37129aa2b90f8
* author: dperkinson, vbraun => David Perkinson, Volker Braun
* branch: u/vbraun/hyperplane_arrangements =>
public/geometry/14789-hyperplane_arrangements
* reviewer: => Travis Scrimshaw
Comment:
Here's the current version with my state of review. However there are two
doctest failures. The first is that
{{{
sage: H.<x,y,z> = HyperplaneArrangements(QQ)
sage: H(x) == 0
Exception raised:
Traceback (most recent call last):
File "/home/travis/sage/local/lib/python2.7/site-
packages/sage/doctest/forker.py", line 480, in _run
self.execute(example, compiled, test.globs)
File "/home/travis/sage/local/lib/python2.7/site-
packages/sage/doctest/forker.py", line 839, in execute
exec compiled in globs
File "<doctest
sage.geometry.hyperplane_arrangement.arrangement.HyperplaneArrangementElement.__cmp__[2]>",
line 1, in <module>
H(x) == Integer(0)
File "element.pyx", line 914, in
sage.structure.element.Element.__richcmp__ (sage/structure/element.c:8876)
File "element.pyx", line 855, in
sage.structure.element.Element._richcmp (sage/structure/element.c:8221)
File "coerce.pyx", line 921, in
sage.structure.coerce.CoercionModel_cache_maps.canonical_coercion
(sage/structure/coerce.c:8568)
File "coerce_maps.pyx", line 82, in
sage.structure.coerce_maps.DefaultConvertMap_unique._call_
(sage/structure/coerce_maps.c:3856)
File "coerce_maps.pyx", line 77, in
sage.structure.coerce_maps.DefaultConvertMap_unique._call_
(sage/structure/coerce_maps.c:3757)
File "/home/travis/sage/local/lib/python2.7/site-
packages/sage/geometry/hyperplane_arrangement/arrangement.py", line 2124,
in _element_constructor_
raise ValueError('linear expression must be non-constant to define
a hyperplane')
ValueError: linear expression must be non-constant to define a
hyperplane
}}}
so it seems like it's trying to coerce 0 into `H`, but that is failing.
The second is that 0-dimensional hyperplane arrangements don't have an
`_an_element_()`. If we can't create 0-dim hyperplane arrangements, then
we shouldn't allow things like `HyperplaneArrangements(QQ)`.
I've taken care of the pyflakes report and the long doctest failure.
----
Last 10 new commits:
||[[http://git.sagemath.org/sage.git/commit/?id=7a7c6ac|7a7c6ac]]||Fixed
long doctest.||
||[[http://git.sagemath.org/sage.git/commit/?id=d19efda|d19efda]]||Doctest
fixes.||
||[[http://git.sagemath.org/sage.git/commit/?id=9383197|9383197]]||More
fixes and pyflakes cleanup.||
||[[http://git.sagemath.org/sage.git/commit/?id=1052df7|1052df7]]||Initial
documentation fixes.||
||[[http://git.sagemath.org/sage.git/commit/?id=0a85ee2|0a85ee2]]||Merge
branch 'master' into ticket/14789||
||[[http://git.sagemath.org/sage.git/commit/?id=253e472|253e472]]||new
vertices() method to compute the vertices of the arrangement||
||[[http://git.sagemath.org/sage.git/commit/?id=ddfbe52|ddfbe52]]||made
the construction of the regions much faster||
||[[http://git.sagemath.org/sage.git/commit/?id=47ac1cf|47ac1cf]]||lazy
import hyperplane arrangements||
||[[http://git.sagemath.org/sage.git/commit/?id=0786df0|0786df0]]||added
remaining functionality, fixed documentation||
||[[http://git.sagemath.org/sage.git/commit/?id=577d09c|577d09c]]||Ported
hyperplanes and arrangements to linear expressions||
--
Ticket URL: <http://trac.sagemath.org/ticket/14789#comment:53>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica,
and MATLAB
--
You received this message because you are subscribed to the Google Groups
"sage-trac" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
To post to this group, send email to [email protected].
Visit this group at http://groups.google.com/group/sage-trac.
For more options, visit https://groups.google.com/groups/opt_out.
