#11868: PARI library interface broken by design
---------------------------------------+------------------------------
Reporter: jdemeyer | Owner: was
Type: defect | Status: needs_review
Priority: major | Milestone: sage-5.13
Component: interfaces | Resolution:
Keywords: t0GEN t1GEN gen | Merged in:
Authors: Peter Bruin | Reviewers: Jeroen Demeyer
Report Upstream: N/A | Work issues:
Branch: | Commit:
Dependencies: #864, #9640, #10018 | Stopgaps:
---------------------------------------+------------------------------
Comment (by pbruin):
Replying to [comment:26 jdemeyer]:
> I added some small changes, see [attachment:11868_pari_extra.patch].
It's not strictly a reviewer patch, since many changes are unrelated to
this ticket but just small things I observed while checking your patch.
I will look at this more carefully later; just two questions for now:
- What exactly is a dangerous `malloc()`?
- In some places (e.g. `isprime()`), doing `P.clear_stack()` instead of
`pari_catch_sig_off()` is clearly better because we call a PARI function
returing a `GEN` that would otherwise be left on the stack. In other
cases (e.g. `ispseudoprime()`) we only call a PARI function returning
`long`; is `clear_stack()` really necessary here?
--
Ticket URL: <http://trac.sagemath.org/ticket/11868#comment:27>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica,
and MATLAB
--
You received this message because you are subscribed to the Google Groups
"sage-trac" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
To post to this group, send email to [email protected].
Visit this group at http://groups.google.com/group/sage-trac.
For more options, visit https://groups.google.com/groups/opt_out.
