#15422: factorization of non-squarefree polynomials over the p-adics
----------------------------------+--------------------------
Reporter: jdemeyer | Owner:
Type: defect | Status: needs_work
Priority: major | Milestone: sage-5.13
Component: padics | Resolution:
Keywords: | Merged in:
Authors: Jeroen Demeyer | Reviewers:
Report Upstream: N/A | Work issues:
Branch: | Commit:
Dependencies: #9640 | Stopgaps:
----------------------------------+--------------------------
Changes (by roed):
* status: needs_review => needs_work
Comment:
'''polynomial_padic.py'''
* uniformizer_pow rather than prime_pow on line 155
* rather than raising an `ArithmeticError` on line 159, we should use
gcds to return the square, with half the precision. Xavier Caruso and I
are working on precision in p-adic factoring. In the mean time, I would
prefer to switch this to a `NotImplementedError`. This will change some
doctests (line 114 for example).
'''polynomial_element.pyx'''
* Need to update the doctest on line 5327.
'''polynomial_integer_dense_flint.pyx'''
* The output of factor_padic on line 1277 should be "factorization of
self over the completion at `p`"
'''polynomial_integer_dense_ntl.pyx'''
* The output of factor_padic on line 1002 should be "factorization of
self over the completion at `p`"
'''polynomial_rational_flint.pyx'''
* Need to update the doctest on line 1585.
This patch changes the behavior of content for p-adic polynomials, from
returning an element to returning an ideal. I have no problem with that
change, but I thought that it should be remarked.
Other than these comments, I'm happy with the changes.
--
Ticket URL: <http://trac.sagemath.org/ticket/15422#comment:17>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica,
and MATLAB
--
You received this message because you are subscribed to the Google Groups
"sage-trac" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
To post to this group, send email to [email protected].
Visit this group at http://groups.google.com/group/sage-trac.
For more options, visit https://groups.google.com/groups/opt_out.
