#4337: [with patch, with positive review, with referee's patch] modular forms --
compute action of Hecke operators on Gamma_1(N) modular forms
---------------------------+------------------------------------------------
Reporter: was | Owner: davidloeffler
Type: defect | Status: assigned
Priority: major | Milestone: sage-4.0
Component: modular forms | Keywords:
---------------------------+------------------------------------------------
Comment(by craigcitro):
This looks really good. Positive review! Here are my comments:
* I'm really happy to see that this code is written! I'm very happy with
how all the code works. This is actually functionality that Magma doesn't
even have. Bravo, David!
* I moved a few bits of code around, and did a few things to make the
code run faster. On the (few) benchmarks I was running, I got a factor of
2 speedup for `_compute_hecke_matrix` on cuspidal subspaces, and about 1.5
on the Eisenstein part. (There's more post-processing to be done in the
Eisenstein case.)
* Unfortunately, this algorithm gets slow pretty fast. For instance,
trying to compute the Hecke operators on something like
`ModularForms(Gamma1(48),4)` is just hopeless in this case. We should try
to talk about what else we could do that might scale a little better. But
we '''definitely''' want this merged first!
David, I've added a few changes in my referee patch -- could you look over
the changes and make sure you're okay with them? Most of it is just
cleanup; the only change I'd really demand is renaming the variable you
called `QQ`, since I think it's pretty confusing to have a local variable
named `QQ`, even if it's going to be the global `QQ` 99% of the time.
--
Ticket URL: <http://trac.sagemath.org/sage_trac/ticket/4337#comment:2>
Sage <http://sagemath.org/>
Sage - Open Source Mathematical Software: Building the Car Instead of
Reinventing the Wheel
--~--~---------~--~----~------------~-------~--~----~
You received this message because you are subscribed to the Google Groups
"sage-trac" group.
To post to this group, send email to [email protected]
To unsubscribe from this group, send email to
[email protected]
For more options, visit this group at
http://groups.google.com/group/sage-trac?hl=en
-~----------~----~----~----~------~----~------~--~---
