#15303: Coercion discovery fails to be transitive
-------------------------------------+-------------------------------------
Reporter: nbruin | Owner:
Type: defect | Status: needs_review
Priority: major | Milestone: sage-6.0
Component: coercion | Resolution:
Keywords: | Merged in:
Authors: Simon King | Reviewers:
Report Upstream: N/A | Work issues: Crash in permgroup.py
Branch: | Commit:
u/SimonKing/ticket/15303 | 528a03535447d67f04dc16d0a22cc38def54f9f1
Dependencies: #14711, #15329, | Stopgaps:
#15331 |
-------------------------------------+-------------------------------------
Comment (by SimonKing):
Replying to [comment:115 mmezzarobba]:
> To see the effect of a merge, you can try viewing the "combined diff" of
HEAD and both parents (`git show HEAD`). But this will omit all files that
agree entirely with ''either'' of the parents. Also, the output will
include the parts of the merge that were automatically resolved.
I see. So, you took the version of `src/sage/misc/weak_dictionary.pyx`
from master, and ...
> All I did manually was to choose the version of `morphism.pyx` that
looked more recent,
I have not even been aware that this has changed. So, someone has made
morphisms that are defined by generator images hashable? Nice!
> and to merge the imports of `morphism.py` as follows:
> {{{
> -from sage.categories.homset import Homset
> +from sage.categories.homset import Homset, Hom
> - from sage.rings.all import is_RingHomomorphism,
is_CommutativeRing,
> + from sage.rings.all import Integer
> + from sage.rings.commutative_ring import is_CommutativeRing
> + from sage.rings.morphism import is_RingHomomorphism
> }}}
Didn't you also do something with `src/sage/combinat/ncsf_qsym/ncsf.py`?
Anyway, the output of `git show HEAD` looks good to me. So, I will try
`make ptest` now. Is "crash in pergroup.py" still an issue? We will see...
--
Ticket URL: <http://trac.sagemath.org/ticket/15303#comment:116>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica,
and MATLAB
--
You received this message because you are subscribed to the Google Groups
"sage-trac" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
To post to this group, send email to [email protected].
Visit this group at http://groups.google.com/group/sage-trac.
For more options, visit https://groups.google.com/groups/opt_out.