#4337: [with patch, needs review] modular forms -- compute action of Hecke
operators on Gamma_1(N) modular forms
---------------------------+------------------------------------------------
Reporter: was | Owner: davidloeffler
Type: defect | Status: assigned
Priority: major | Milestone: sage-4.0
Component: modular forms | Keywords:
---------------------------+------------------------------------------------
Comment(by davidloeffler):
Thanks for reviewing this. I'd actually never come across the python
"for/else" syntax before; it's a neat trick, I'll have to remember it. I'm
happy with the changes you propose.
Unfortunately, I've realised that there *is* a problem in my patch: in
trying to prevent the infinite loop for GammaH, I've broken something
else. The loop comes up because the default behaviour for the generic
cuspidal submodule class is to get its q-expansions from its ambient
space; and the generic ambient space class gets its q-expansions from its
ambient modules.
Now, for *most* derived classes it's the cuspidal and eisenstein subs that
have this overridden, but for the "ambient_R" class, it's the ambient
space that overrides it. So my patch breaks calculation of q-expansion
bases -- and consequently everything else -- for forms over a non-minimal
base ring.
So here's a third patch, which fixes this and adds a doctest.
David
--
Ticket URL: <http://trac.sagemath.org/sage_trac/ticket/4337#comment:3>
Sage <http://sagemath.org/>
Sage - Open Source Mathematical Software: Building the Car Instead of
Reinventing the Wheel
--~--~---------~--~----~------------~-------~--~----~
You received this message because you are subscribed to the Google Groups
"sage-trac" group.
To post to this group, send email to [email protected]
To unsubscribe from this group, send email to
[email protected]
For more options, visit this group at
http://groups.google.com/group/sage-trac?hl=en
-~----------~----~----~----~------~----~------~--~---
