#6009: [with patch, needs review] Bring plot/text.py to 100%
---------------------------+------------------------------------------------
Reporter: kcrisman | Owner: kcrisman
Type: enhancement | Status: assigned
Priority: minor | Milestone: sage-4.0
Component: documentation | Keywords:
---------------------------+------------------------------------------------
Comment(by mvngu):
REFEREE REPORT
[[BR]][[BR]]
The patch {{{trac_6009.patch}}} applies OK against the "post-final"
sage-3.4.2, all doctests pass with the options {{{-t -long}}}. The
reference manual built fine, but note that {{{sage/plot/text.py}}} is not
included in the reference manual so don't be surprised when you can't
search for {{{sage/plot/text.py}}} in the reference manual. The doctest
coverage for {{{sage/plot/text.py}}} is 100% as claimed.
[[BR]][[BR]]
However, I notice that the patch introduces some typos and inconsistencies
into the module {{{sage/plot/text.py}}}. These are fixed in the reviewer
patch {{{trac_6009-reviewer.patch}}}. Apart from these issues, positive
review for kcrisman's patch. Only my patch needs to be reviewed.
--
Ticket URL: <http://trac.sagemath.org/sage_trac/ticket/6009#comment:3>
Sage <http://sagemath.org/>
Sage - Open Source Mathematical Software: Building the Car Instead of
Reinventing the Wheel
--~--~---------~--~----~------------~-------~--~----~
You received this message because you are subscribed to the Google Groups
"sage-trac" group.
To post to this group, send email to [email protected]
To unsubscribe from this group, send email to
[email protected]
For more options, visit this group at
http://groups.google.com/group/sage-trac?hl=en
-~----------~----~----~----~------~----~------~--~---
