#6007: [with patch, needs review] Bring plot/primitive.py to 100% coverage
---------------------------+------------------------------------------------
Reporter: kcrisman | Owner: kcrisman
Type: enhancement | Status: assigned
Priority: minor | Milestone: sage-4.0
Component: documentation | Keywords:
---------------------------+------------------------------------------------
Comment(by mvngu):
REFEREE REPORT
[[BR]][[BR]]
The patch {{{trac_6007.patch}}} applies fine against the "post-final"
version sage-3.4.2, all doctests pass with the options {{{-t -long}}}, and
the doctest coverage is 100% as claimed. The reference manual built OK,
but note that {{{sage/plot/primitive.py}}} is not included in the
reference manual, so you can't search for the module in it.
[[BR]][[BR]]
On the side of pedantry, the patch introduces a trivial inconsistency in
how "two-dimensional" and "three-dimensional" are abbreviated. So all such
references in the module {{{sage/plot/primitive.py}}} now follow the forms
{{{2D}}} and {{{3D}}}. Apart from this trivial issue of inconsistency
which is fixed in {{{trac_6007-reviewer.patch}}}, positive review for
kcrisman's patch. Only my patch needs to be reviewed.
--
Ticket URL: <http://trac.sagemath.org/sage_trac/ticket/6007#comment:4>
Sage <http://sagemath.org/>
Sage - Open Source Mathematical Software: Building the Car Instead of
Reinventing the Wheel
--~--~---------~--~----~------------~-------~--~----~
You received this message because you are subscribed to the Google Groups
"sage-trac" group.
To post to this group, send email to [email protected]
To unsubscribe from this group, send email to
[email protected]
For more options, visit this group at
http://groups.google.com/group/sage-trac?hl=en
-~----------~----~----~----~------~----~------~--~---
