#15488: Fix misplaced sig_on() inside try
----------------------------------+----------------------------
Reporter: jdemeyer | Owner:
Type: defect | Status: needs_review
Priority: major | Milestone: sage-5.13
Component: c_lib | Resolution:
Keywords: | Merged in:
Authors: Jeroen Demeyer | Reviewers:
Report Upstream: N/A | Work issues:
Branch: | Commit:
Dependencies: | Stopgaps:
----------------------------------+----------------------------
Comment (by pbruin):
Replying to [comment:3 jdemeyer]:
> > * Why do you replace `ValueError` by `BaseException` ?
> Because the only purpose of that `except` branch is to put the object in
a consistent state before re-raising the exception. I guess the "putting
the object in a consistent state" part should also be done when other
exceptions happen.
And `except BaseException:` is equivalent to `except:`, since all
exceptions derive from `BaseException`, don't they? The second form looks
slightly clearer to me.
--
Ticket URL: <http://trac.sagemath.org/ticket/15488#comment:7>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica,
and MATLAB
--
You received this message because you are subscribed to the Google Groups
"sage-trac" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
To post to this group, send email to [email protected].
Visit this group at http://groups.google.com/group/sage-trac.
For more options, visit https://groups.google.com/groups/opt_out.
