#15367: Empty lists while creating parents
-------------------------------------+-------------------------------------
Reporter: roed | Owner:
Type: enhancement | Status: needs_review
Priority: major | Milestone: sage-5.13
Component: coercion | Resolution:
Keywords: | Merged in:
Authors: Nils Bruin | Reviewers: Simon King
Report Upstream: N/A | Work issues:
Branch: | Commit:
u/nbruin/ticket/15367 | 719cdec176875685142039dce297a7fd8ae4143b
Dependencies: | Stopgaps:
-------------------------------------+-------------------------------------
Comment (by nbruin):
*ping*
I think this straightforward replacement is worth merging:
- memory layout is more straightforward: If you want to trace a memory
leak/reference chain, you immediately get to the MonoDict/TripleDict
rather than having to dig through 2 levels of lists
- memory footprint is much more compact
- performance should be quite a bit better (although it seems that these
dicts rarely get accessed in tight loops: optimizing such a loop usually
removes the access to these dicts)
- the way items get deleted makes sure that the Python trashcan is
involved, which prevents recursion depth errors from occurring when
deleting long chains of objects.
So, if someone can finish the review ... It's pretty straightforward code
(apart from being rather performance sensitive).
--
Ticket URL: <http://trac.sagemath.org/ticket/15367#comment:44>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica,
and MATLAB
--
You received this message because you are subscribed to the Google Groups
"sage-trac" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
To post to this group, send email to [email protected].
Visit this group at http://groups.google.com/group/sage-trac.
For more options, visit https://groups.google.com/groups/opt_out.
