#5787: [with third patch, needs review] Improve doctest coverage for
sage/modular/hecke (continued)
---------------------------+------------------------------------------------
Reporter: davidloeffler | Owner: davidloeffler
Type: enhancement | Status: assigned
Priority: major | Milestone: sage-4.0
Component: modular forms | Keywords: doctests
---------------------------+------------------------------------------------
Comment(by davidloeffler):
On inspection, it turns out that the {{{__cmp__}}} routine was written
stupidly anyway, so I rewrote it. Hence the third patch above. So now
applying trac_5787-all.patch, trac_5787_pt2_rebased.patch, and
trac_5787_pt3.patch (on top of the already-merged #5736 patches and #4357)
should not conflict -- at least it doesn't on my machine.
Craig: I'm entirely happy with the rest of your changes, so if you could
just check to make sure that applying #5736 + #4357 + the patches here
works for you and passes doctests, I think we can call this a positive
review at last.
--
Ticket URL: <http://trac.sagemath.org/sage_trac/ticket/5787#comment:7>
Sage <http://sagemath.org/>
Sage - Open Source Mathematical Software: Building the Car Instead of
Reinventing the Wheel
--~--~---------~--~----~------------~-------~--~----~
You received this message because you are subscribed to the Google Groups
"sage-trac" group.
To post to this group, send email to [email protected]
To unsubscribe from this group, send email to
[email protected]
For more options, visit this group at
http://groups.google.com/group/sage-trac?hl=en
-~----------~----~----~----~------~----~------~--~---
