#15367: Empty lists while creating parents
-------------------------------------+-------------------------------------
       Reporter:  roed               |        Owner:
           Type:  enhancement        |       Status:  needs_info
       Priority:  major              |    Milestone:  sage-6.1
      Component:  coercion           |   Resolution:
       Keywords:                     |    Merged in:
        Authors:  Nils Bruin         |    Reviewers:  Simon King
Report Upstream:  N/A                |  Work issues:
         Branch:                     |       Commit:
  u/nbruin/ticket/15367              |  719cdec176875685142039dce297a7fd8ae4143b
   Dependencies:                     |     Stopgaps:
-------------------------------------+-------------------------------------
Changes (by SimonKing):

 * status:  needs_review => needs_info


Comment:

 In `MonoDict.set`, there is
 {{{
         cursor = self.lookup(<PyObject*><void*>k)
         if cursor.key_id == NULL or cursor.key_id == dummy:
             ...
 }}}
 ''without'' saying that `cursor` is `cdef mono_cell*`. Similar things
 happen in `MonoDict.iteritems`, `Monodict_traverse` and `MonoDict_clear`,
 and also in `TripleDict.set`, `TripleDict.iteritems`,
 `TripleDict_traverse` and `TripleDict_clear`.

 First question: Why does it not crash? Even if there is a good reason for
 not crashing: Shouldn't it be `cdef mono_cell*`d resp. `cdef
 triple_cell*`d in order to improve performance?

--
Ticket URL: <http://trac.sagemath.org/ticket/15367#comment:55>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica, 
and MATLAB

-- 
You received this message because you are subscribed to the Google Groups 
"sage-trac" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to [email protected].
To post to this group, send email to [email protected].
Visit this group at http://groups.google.com/group/sage-trac.
For more options, visit https://groups.google.com/groups/opt_out.

Reply via email to