#15523: Add precision arguments in PARI
-------------------------------------+-------------------------------------
       Reporter:  jdemeyer           |        Owner:
           Type:  enhancement        |       Status:  needs_review
       Priority:  major              |    Milestone:  sage-6.1
      Component:  interfaces         |   Resolution:
       Keywords:                     |    Merged in:
        Authors:  Jeroen Demeyer     |    Reviewers:
Report Upstream:  N/A                |  Work issues:
         Branch:                     |       Commit:
  u/jdemeyer/ticket/15523            |  520f0438e74d9b0a706a48da01c5464dfa59a1a8
   Dependencies:  #15461             |     Stopgaps:
-------------------------------------+-------------------------------------

Comment (by pbruin):

 Looks good.  There is one point where I don't understand your patch and
 where I would make the following change:
 {{{
 #!diff
 diff --git a/src/sage/libs/pari/gen_py.py b/src/sage/libs/pari/gen_py.py
 index 29aae82..c0efe22 100644
 --- a/src/sage/libs/pari/gen_py.py
 +++ b/src/sage/libs/pari/gen_py.py
 @@ -53,8 +53,8 @@ def pari(x):
          sage: pari.set_real_precision(15)
          35

 -    Conversion from matrices is supported, but not from vectors or
 tuples;
 -    use lists instead::
 +    Conversion from matrices is supported, but not from vectors;
 +    use lists or tuples instead::

          sage: a = pari(matrix(2,3,[1,2,3,4,5,6])); a, a.type()
          ([1, 2, 3; 4, 5, 6], 't_MAT')
 @@ -66,6 +66,8 @@ def pari(x):
          PariError: syntax error, unexpected ')', expecting )-> or ','
          sage: b = pari(list(v)); b,b.type()
          ([1.20000000000000, 3.40000000000000, 5.60000000000000], 't_VEC')
 +        sage: b = pari(tuple(v)); b, b.type()
 +        ([1.20000000000000, 3.40000000000000, 5.60000000000000], 't_VEC')

      Some more exotic examples::

 }}}
 Or are there other tuples that aren't converted correctly?

 Apart from that, positive review.

--
Ticket URL: <http://trac.sagemath.org/ticket/15523#comment:18>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica, 
and MATLAB

-- 
You received this message because you are subscribed to the Google Groups 
"sage-trac" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to [email protected].
To post to this group, send email to [email protected].
Visit this group at http://groups.google.com/group/sage-trac.
For more options, visit https://groups.google.com/groups/opt_out.

Reply via email to