#15432: Use a callback with a weak reference to WeakValueDictionary
-------------------------------------+-------------------------------------
Reporter: nbruin | Owner:
Type: enhancement | Status: needs_review
Priority: major | Milestone: sage-6.1
Component: memleak | Resolution:
Keywords: | Merged in:
Authors: Nils Bruin | Reviewers: Simon King
Report Upstream: N/A | Work issues:
Branch: | Commit:
u/nbruin/ticket/15432 | 4ac686619284500adaf201c397a82a9b7409e41f
Dependencies: | Stopgaps:
-------------------------------------+-------------------------------------
Changes (by SimonKing):
* reviewer: => Simon King
Comment:
Hooray! After pulling the correct commit, I get
{{{
sage: TestTcollect(weakref.WeakValueDictionary)
Number of T-objects before we start: 3
Number of T-objects after list construction: 103
Throwing away references:
no GC required to get rid of objects
number of collects required: 0
}}}
and the answer came a lot faster than before. All tests pass, and the
patch (i.e., the diff between the develop branch and this branch after
merging with the develop branch) looks reasonable to me.
Hence, I can ''almost'' give it a positive review. How can I do a review
patch? Is it possible to make some changes and then do `sage --dev push`,
or what is to do for the equivalent of a review patch?
--
Ticket URL: <http://trac.sagemath.org/ticket/15432#comment:21>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica,
and MATLAB
--
You received this message because you are subscribed to the Google Groups
"sage-trac" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
To post to this group, send email to [email protected].
Visit this group at http://groups.google.com/group/sage-trac.
For more options, visit https://groups.google.com/groups/opt_out.
