#15551: Rename Graph.trace_faces to Graph.faces
-------------------------+-------------------------------------------------
Reporter: | Owner:
ncohen | Status: needs_review
Type: | Milestone: sage-6.1
enhancement | Resolution:
Priority: major | Merged in:
Component: graph | Reviewers:
theory | Work issues:
Keywords: | Commit:
Authors: | 51571f7d0bc4078dd08a6481a1e1d7f6430dbd1b
Nathann Cohen | Stopgaps:
Report Upstream: N/A |
Branch: |
u/ncohen/15551 |
Dependencies: |
-------------------------+-------------------------------------------------
Comment (by tscrim):
A few minor things:
- The alignment of the {{{``embedding``}}} input bullet-point is off by a
space (lines 3729-3734).
- Instead of `doctest:1: message` could you change it to the more robust
`doctest:...: message`?
- Could you use `Return` instead of `Returns` on line 3721?
- I believe the error messages should be formatted as `ValueError("lower
case with no period")`.
Otherwise looks good. Thanks.
--
Ticket URL: <http://trac.sagemath.org/ticket/15551#comment:4>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica,
and MATLAB
--
You received this message because you are subscribed to the Google Groups
"sage-trac" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
To post to this group, send email to [email protected].
Visit this group at http://groups.google.com/group/sage-trac.
For more options, visit https://groups.google.com/groups/opt_out.
