#15286: Latin squares
-------------------------+-------------------------------------------------
Reporter: | Owner:
ncohen | Status: needs_review
Type: | Milestone: sage-6.1
enhancement | Resolution:
Priority: major | Merged in:
Component: | Reviewers:
combinatorics | Work issues:
Keywords: | Commit:
Authors: | a8a2a719d1f0fc4aedf24f24fc2c87e407182da4
Nathann Cohen | Stopgaps:
Report Upstream: N/A |
Branch: |
u/ncohen/15286 |
Dependencies: |
#15285 |
-------------------------+-------------------------------------------------
Comment (by ncohen):
Helloooooo !!
> Why this is not included to sage.combinat.matrix.latin_squares ? If you
do not want to merge, you could at least make a reference.
Because I did not know that this module existed when I wrote this one.
"fortunately" they are unrelated : the
`sage.combinat.matrix.latin_squares` module deals with operations specific
to a given latin square, while this module builds "mutually orthogonal
latin squares". I added a comment to the top of the file.
> - The first line in the documentation is too large (146 columns).
Fixed.
> - line 112: "(cite theorem)" is not enough for the `ValueError` message
`T_T`
Sorry 'bout that. It is fixed. I thought this theorem has a name, but it
is just a nameless one in the references I have, so I just replaced this
text by `There exist at most n-1 MOLS of size n.`. And I added a doctest.
> - optimization line 123: replace l == [] by not l
Fixed. Assuming it was `p == []`.
> - could you put the references lines 117 and 140 that are in comments
and I would like better to see them in the documentation
I do not understand your sentence very well `O_o`
This being said, [Stinson2004] does appear in the documentation.
> I will have a look at the mathematics next.
Thaaaaaaaaaaaaaaaaaaaaanks. I'm very very thankful fo that, 'cause I love
all this designs code and there does not seem to be many design lovers
among Sage's devs' `^^;`
Nathann
--
Ticket URL: <http://trac.sagemath.org/ticket/15286#comment:5>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica,
and MATLAB
--
You received this message because you are subscribed to the Google Groups
"sage-trac" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
To post to this group, send email to [email protected].
Visit this group at http://groups.google.com/group/sage-trac.
For more options, visit https://groups.google.com/groups/opt_out.
