#14793: Unique representation for homsets
-------------------------------------+-------------------------------------
Reporter: nthiery | Owner: nthiery
Type: enhancement | Status: needs_review
Priority: major | Milestone: sage-6.1
Component: categories | Resolution:
Keywords: | Merged in:
Authors: Simon King | Reviewers: Travis Scrimshaw
Report Upstream: N/A | Work issues:
Branch: | Commit:
public/structure/unique_repr_homsets-14793|
ea3ecfbc644fa6b53441c25cce73720f9a0ffeee
Dependencies: | Stopgaps:
-------------------------------------+-------------------------------------
Changes (by tscrim):
* commit: => ea3ecfbc644fa6b53441c25cce73720f9a0ffeee
* branch: => public/structure/unique_repr_homsets-14793
* reviewer: => Travis Scrimshaw
Old description:
> The unique representation of homsets is taken care of by ``Hom``. What's
> missing is:
>
> - Fast hash and comparison by id. This can be implemented by having
> Homset inherit from WithEqualityById
> - Pickling by construction, calling back Hom(domain, codomain, category)
>
> __Apply__
>
> * [attachment:trac14793-homset_default_pickling.patch]
New description:
The unique representation of homsets is taken care of by ``Hom``. What's
missing is:
- Fast hash and comparison by id. This can be implemented by having Homset
inherit from WithEqualityById
- Pickling by construction, calling back Hom(domain, codomain, category)
--
Comment:
Made this into a branch and added doctests to added functions and some
other misc review changes. If you're happy with my changes Simon, then
this is a positive review.
----
New commits:
||[[http://git.sagemath.org/sage.git/commit/?id=ea3ecfb|ea3ecfb]]||{{{Some
review changes.}}}||
||[[http://git.sagemath.org/sage.git/commit/?id=1411319|1411319]]||{{{#14793:
Use __reduce__ for pickling homsets, and use WithEqualityById for
them}}}||
--
Ticket URL: <http://trac.sagemath.org/ticket/14793#comment:36>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica,
and MATLAB
--
You received this message because you are subscribed to the Google Groups
"sage-trac" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
To post to this group, send email to [email protected].
Visit this group at http://groups.google.com/group/sage-trac.
For more options, visit https://groups.google.com/groups/opt_out.
