#15567: Fix Alphabet and improvements to Family
-------------------------------------+-------------------------------------
       Reporter:  tscrim             |        Owner:  sage-combinat
           Type:  defect             |       Status:  needs_work
       Priority:  major              |    Milestone:  sage-6.1
      Component:  combinatorics      |   Resolution:
       Keywords:  alphabet           |    Merged in:
        Authors:  Travis Scrimshaw   |    Reviewers:
Report Upstream:  N/A                |  Work issues:
         Branch:                     |       Commit:
  public/combinat/words/fix_alphabet |  b3396dd62e96a08621cf08a6b2573c59a664adac
   Dependencies:                     |     Stopgaps:
-------------------------------------+-------------------------------------

Comment (by ncohen):

 Hellooooooooo !!

 > This is also inconsistent input types (one is a "number", the other is a
 set). However the other could raise an error as invalid input as opposed
 to being silently ignored.

 Oh ? Well, if the second input is not supported so be it. Could you say in
 the docstring of Family what kind of input is expected, then ?

 > This is an issue with `Family` in that it is directly passing a string
 representation of the input of `__getitem__()` without any safety checks
 (for speed). It's outside the scope of what I want to do in this ticket
 and has a landmine of "you've picked a specific ordering of the indices
 that may not be canonical".

 Well there has to be a bug somewhere, this container is returning
 something totally crazy when one uses a basic list operation on it `O_o`

 I don't even understand how the string representation can get to replace
 the content itself `O_o`

 > It means they are valid keys (indices) of the Family that are hidden.

 And what does hidden mean ? That they are skipped when one list the
 elements, or that they do not appear in the string representation
 `__repr__` of the object ?... As it is, I don't get what this argument
 actually does.

 > So lazy familys display nicely (espically when using lambda functions).

 Okay. Could you then say so in the docstring ? "name" only has an effect
 when the input defines a lambda function, if that's the explanation ?

 Nathann

--
Ticket URL: <http://trac.sagemath.org/ticket/15567#comment:4>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica, 
and MATLAB

-- 
You received this message because you are subscribed to the Google Groups 
"sage-trac" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to [email protected].
To post to this group, send email to [email protected].
Visit this group at http://groups.google.com/group/sage-trac.
For more options, visit https://groups.google.com/groups/opt_out.

Reply via email to