#15278: Hash and equality for graphs
-------------------------------------+-------------------------------------
Reporter: SimonKing | Owner:
Type: defect | Status: positive_review
Priority: major | Milestone: sage-6.1
Component: graph theory | Resolution:
Keywords: | Merged in:
Authors: Simon King | Reviewers: Nathann Cohen
Report Upstream: N/A | Work issues:
Branch: | Commit:
u/SimonKing/ticket/15278 | 2525d22a6b3a687bf932c2afaa8297e40c7af3d8
Dependencies: #12601, #15491 | Stopgaps:
-------------------------------------+-------------------------------------
Changes (by ncohen):
* status: needs_review => positive_review
Comment:
> Fixed the syntax error, and checked that the failing test passes.
Yep. And they just passed on my computer too in graph/ combinat/ and
misc/. Soooo `positive_review` again !
> So, with the last two commits, we counter-hacked the hack with the
`._immutable` attribute.
Nod.
> Next step will be to make #15603 ready (can you merge the missing
commits from here into #15603, please?)
Nod. Plus I will probably have some conflicts because of what I do in
`.__copy__`. Shouldn't be very long.
> and in a third step, we will properly remove the hack and perhaps the
counter-hack too.
Nod.
I fear that there may be nasty surprises hiding, though. For instance, I'm
rather convinced that the static backend will produce a HUGE slowdown in
their code, because right now distance computations (which translates as
comparison in posets) is done by some code specific to the sparse backend.
And thus does not exist for the static backend. So this will have to be
written too. And then it should be much faster `;-)`
Nathann
P.S. : it takes a lifetime to add a comment on a ticket.
--
Ticket URL: <http://trac.sagemath.org/ticket/15278#comment:80>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica,
and MATLAB
--
You received this message because you are subscribed to the Google Groups
"sage-trac" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
To post to this group, send email to [email protected].
Visit this group at http://groups.google.com/group/sage-trac.
For more options, visit https://groups.google.com/groups/opt_out.
