#15550: Implement the Kirchhoff-Symanzik polynomial for graphs
-------------------------------------+-------------------------------------
Reporter: chapoton | Owner:
Type: enhancement | Status: needs_work
Priority: minor | Milestone: sage-6.1
Component: graph theory | Resolution:
Keywords: symanzik | Merged in:
polynomial | Reviewers:
Authors: | Work issues:
Report Upstream: N/A | Commit:
Branch: u/chapoton/15550 | 13a16d42a8c1c17b6726487b7e2f1aa311c7b51c
Dependencies: | Stopgaps:
-------------------------------------+-------------------------------------
Comment (by ncohen):
Hellooooooooo !
> Would you prefer if I put my auxiliary function inside the new method ?
Your auxiliary method will not be in your final patch, that's for sure,
because even if it were actually useful for your code it has no general
use and has nothing to do has a Graph function. At the very least it
should be made private. This being said, you still haven't explained to me
what exactly this function does (neither is it explained in the function's
docstring), so I do not understand how to help you remove it yet. Please
tell me what exactly it does. Right now its docstring reads "return the
only cycle of a graph with one cycle", and that's exactly what `is_forest`
does for you, thus something is missing.
> I do not see how to avoid it completely. I need to choose an arbitray
orientation of the graph, and for this I am using the way the edges are
given by a pair (i,j). Then I need to know how every cycle is oriented,
some arrows being in the wrong direction.
I do not know what you need this orientation for, but using the
orientation given by `edges()` can be tricky. There is absolutely no
certainty that the orientation of the edges given by `edges()` is
consistent with the one given by `edges_incident()`.
> Is this really necessary to smash all my commits (not patches) into one
? I would prefer not to.
It would make your patch clearer. There are 5 commits in your patch right
now and most of what one does is undone in the other. This being said
merging commits is *very easy* to do in git : you have to "rebase" your
ticket's branch upon "develop" using the '-i' flag, for "interactive". In
only one command you can merge commits together (I think 'git' uses the
keyword 'meld' instead). That's actually quite cool `:-P`
Nathann
--
Ticket URL: <http://trac.sagemath.org/ticket/15550#comment:10>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica,
and MATLAB
--
You received this message because you are subscribed to the Google Groups
"sage-trac" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
To post to this group, send email to [email protected].
Visit this group at http://groups.google.com/group/sage-trac.
For more options, visit https://groups.google.com/groups/opt_out.
