#15576: Semimonomial transformation groups code is sensitive to Permutations
global
options
-------------------------------------+-------------------------------------
Reporter: darij | Owner:
Type: defect | Status: new
Priority: major | Milestone: sage-6.1
Component: group theory | Resolution:
Keywords: permutation, | Merged in:
semimonomial transformation, | Reviewers:
groups | Work issues:
Authors: | Commit:
Report Upstream: N/A | d8cd6e3c3a59c98b3b68f2de22e12b805ffbdc23
Branch: | Stopgaps:
u/tfeulner/ticket/15576 |
Dependencies: |
-------------------------------------+-------------------------------------
Comment (by darij):
Where does `Permutation.action` depend on the multiplication order? I
agree, the function isn't very useful because it's easier to write it
oneself than to figure out what exactly it does; but it seems to be self-
contained. (It also has significant space for optimization... whoever
wrote it seems not to have realized that permutations can be iterated
over. I'll fix this in a separate ticket.)
I prefer using `R^{\times}` instead of `R*` for the multiplicative group
of units of `R` (the latter notation could be a dual of `R` and either way
seems to be a typographic substitute), but this is probably a judgment
call (particularly seeing that you use `*` for multiplication).
In
{{{
`\psi^{\pi, \alpha} = (\alpha(\psi_{\pi(0)}), \ldots,
\alpha(\psi_{\pi(n-1)}))`
}}}
you are using 0-based indexing of permutations; I'm not sure if this is
what you want (it's doc, not code).
You speak of the semimonomial group over a ring R of either "length n" (in
the definition) or "degree n" (in other parts of the doc). I think it
would help to settle upon one notation (or define them both).
Other than this, the code looks fine. Thanks for the quick response, and
set this to positive_review once the above issues are fixed!
--
Ticket URL: <http://trac.sagemath.org/ticket/15576#comment:6>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica,
and MATLAB
--
You received this message because you are subscribed to the Google Groups
"sage-trac" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
To post to this group, send email to [email protected].
Visit this group at http://groups.google.com/group/sage-trac.
For more options, visit https://groups.google.com/groups/opt_out.
