#15552: enumerate_totallyreal_fields_prim does not return polynomial as
elements of
a polynomial ring
-------------------------------------+-------------------------------------
Reporter: ppurka | Owner:
Type: defect | Status: needs_work
Priority: major | Milestone: sage-6.1
Component: algebra | Resolution:
Keywords: | Merged in:
Authors: | Reviewers: Francis Clarke
Report Upstream: N/A | Work issues:
Branch: | Commit:
u/ppurka/ticket/15552 | a31f831bfd92e4fa139d12f951b7b12be9a41c55
Dependencies: | Stopgaps:
-------------------------------------+-------------------------------------
Changes (by fwclarke):
* status: needs_review => needs_work
* commit: => a31f831bfd92e4fa139d12f951b7b12be9a41c55
* reviewer: => Francis Clarke
Comment:
The patches do not deal with the trivial `n=1` case
of`enumerate_totallyreal_fields_prim`. However, the code for this trivial
case has ''never'' worked. It needs to be moved earlier, before the line
{{{
T = tr_data(n_int,B,a)
}}}
which causes an error when `n==1` (because of a call to
`hermite_constant(0)`). Similar remarks apply to
`enumerate_totallyreal_fields_rel` when `m=1`.
There are many other problems with these functions:
* poor documentation (e.g., the meaning of the four integers `counts`
which are output when `return_seqs=True` is not explained);
* other features not standard in Sage (e.g., built-in file output);
* too few doctests;
* over-dependence on PARI (e.g., the following works, as in the doctest:
{{{
sage: enumerate_totallyreal_fields_rel(NumberField(x^2 - 2, 't'), 2, 2000)
[[1600, x^4 - 6*x^2 + 4, xF^2 + xF - 1]]
}}}
but
{{{
sage: enumerate_totallyreal_fields_rel(NumberField(x^2 - 2, 'a'), 2, 2000)
Traceback (most recent call last)
...
PariError: incorrect type in gsigne
}}}
In Sage, unlike PARI, the names of variable/generators should not matter.)
But I suppose these are for a different ticket.
----
New commits:
||[[http://git.sagemath.org/sage.git/commit/?id=a31f831|a31f831]]||{{{add
more fixes for enumerate_totallyreal_*}}}||
||[[http://git.sagemath.org/sage.git/commit/?id=aa82d85|aa82d85]]||{{{fix
output of enumerate_totallyreal_*}}}||
--
Ticket URL: <http://trac.sagemath.org/ticket/15552#comment:6>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica,
and MATLAB
--
You received this message because you are subscribed to the Google Groups
"sage-trac" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
To post to this group, send email to [email protected].
Visit this group at http://groups.google.com/group/sage-trac.
For more options, visit https://groups.google.com/groups/opt_out.
