#15550: Implement the Kirchhoff-Symanzik polynomial for graphs
-------------------------------------+-------------------------------------
Reporter: chapoton | Owner:
Type: enhancement | Status: needs_review
Priority: minor | Milestone: sage-6.1
Component: graph theory | Resolution:
Keywords: symanzik | Merged in:
polynomial | Reviewers:
Authors: Frédéric Chapoton | Work issues:
Report Upstream: N/A | Commit:
Branch: u/chapoton/15550 | e68f25d800b1fe775821c663b7899060b74211db
Dependencies: | Stopgaps:
-------------------------------------+-------------------------------------
Comment (by ncohen):
Hello !
> I have now added some code to cycle_basis
>
> But one cannot reconstruct a cycle from its support in a graph with
multiple edges, so I cannot use that, unless I change the output of
cycle_basis to a list of edges.
Well, the best way would be to add a flag to `cycle_basis` to ask
precisely this : how should the output be given ? While saying that of
course the "vertex" output cannot be used if the graph has multiple edges.
> When you tell me you want more explanations, do you mean
> * here in trac
> * as comments in the code
> * in the doc of the code ?
I would personally like it very much if you could answer the questions I
ask here with real words and not only with git commits. Then, the problem
is the following : the code is clearly not documented properly, as I
cannot understand what it does, and I can swear this review costed me a
lot of time already.
I would like to understand clearly the orientation that you pick, and all
steps that you use to build the matrix, then to compute the coefficients.
Besides, this should be written somewhere, in the docstring or as comments
in the code.
Nathann
--
Ticket URL: <http://trac.sagemath.org/ticket/15550#comment:24>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica,
and MATLAB
--
You received this message because you are subscribed to the Google Groups
"sage-trac" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
To post to this group, send email to [email protected].
Visit this group at http://groups.google.com/group/sage-trac.
For more options, visit https://groups.google.com/groups/opt_out.
