#15626: Further improvements to splitting_field()
-------------------------------------+-------------------------------------
Reporter: jdemeyer | Owner:
Type: enhancement | Status: positive_review
Priority: major | Milestone: sage-6.1
Component: number fields | Resolution:
Keywords: | Merged in:
Authors: Jeroen Demeyer | Reviewers: John Cremona
Report Upstream: N/A | Work issues:
Branch: | Commit:
u/jdemeyer/ticket/15626 | 776795d8eae9b2d4751fdb5968bf4c3a06539914
Dependencies: #2217 | Stopgaps:
-------------------------------------+-------------------------------------
Changes (by cremona):
* status: needs_review => positive_review
* reviewer: => John Cremona
Comment:
The Abort class is a great idea and very well implemented. It would never
have occurred to me to implement the early abort this way, and it has led
me to think about other situations where a similar strategy might be
useful! The examples are good.
All tests in sage/rings pass. For some reason when I tested the whole of
Sage built with this branch I got various doctest errors in sage/crypto
but I cannot believe that it has anything to do with these changes, so
they are not stopping me giving it a positive review. Now I am looking
forward to looking at the elliptic curve division field code!
--
Ticket URL: <http://trac.sagemath.org/ticket/15626#comment:11>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica,
and MATLAB
--
You received this message because you are subscribed to the Google Groups
"sage-trac" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
To post to this group, send email to [email protected].
Visit this group at http://groups.google.com/group/sage-trac.
For more options, visit https://groups.google.com/groups/opt_out.
