#12561: Factoring padic polynomials
-------------------------------------+-------------------------------------
Reporter: bsinclai | Owner: roed
Type: enhancement | Status: needs_review
Priority: major | Milestone: sage-6.1
Component: padics | Resolution:
Keywords: | Merged in:
Authors: Brian Sinclair, | Reviewers:
Sebastian Pauli | Work issues:
Report Upstream: N/A | Commit:
Branch: | e1bb657e7131cc02d0da9f787072d441fb1ea0de
u/bsinclai/ticket/12561 | Stopgaps:
Dependencies: #15190 |
-------------------------------------+-------------------------------------
Comment (by jdemeyer):
Some comments (not planning to actually review this):
1. I would hope that this code works for all kinds of p-adic polynomials
(over `Zp`, over `Qp`, over field extensions, all with different kinds of
precision). Still, (almost) all examples in the doctests use `ZpFM`.
1. The `factor()` method doesn't actually use this code. What's the point
then?
1. It would be good if this code would also support the `factor_padic()`
method for polynomials over `ZZ` and `QQ`.
1. What happens if the assumption the the polynomial is squarefree doesn't
hold?
1. Units in the `Factorization` should be put in the "unit" part, this is
wrong:
{{{
sage: x = polygen(ZpFM(2,10))
sage: pfactor(3*x)[1]
(1 + 2 + O(2^10), 1)
}}}
1. Similarly, the primes should actually be primes, this should have a
factor 2 with multiplicity 2:
{{{
sage: x = polygen(ZpFM(2,10))
sage: pfactor(4*x)[1]
(2^2 + O(2^10), 1)
}}}
--
Ticket URL: <http://trac.sagemath.org/ticket/12561#comment:21>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica,
and MATLAB
--
You received this message because you are subscribed to the Google Groups
"sage-trac" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
To post to this group, send email to [email protected].
Visit this group at http://groups.google.com/group/sage-trac.
For more options, visit https://groups.google.com/groups/opt_out.
