#15662: Ihara zeta function of graphs
-------------------------+-------------------------------------------------
Reporter: | Owner:
chapoton | Status: positive_review
Type: | Milestone: sage-6.1
enhancement | Resolution:
Priority: major | Merged in:
Component: graph | Reviewers: Nathann Cohen
theory | Work issues:
Keywords: zeta | Commit:
function | 403fd968aefe0eaf3b9e72f4ec79ba8ac7d9aad5
Authors: | Stopgaps:
Frédéric Chapoton |
Report Upstream: N/A |
Branch: |
public/15662 |
Dependencies: |
-------------------------+-------------------------------------------------
Changes (by ncohen):
* status: needs_review => positive_review
* reviewer: => Nathann Cohen
Comment:
Yoooooooo !
> Nathann, it seems that you have not pulled the latest version (done
yesterday evening) which corrects the names and minor details !
`T_T`
Sorry again. I had noted somewhere in my head that this had to be done,
and forgot that you had changed the name of the function since. Sorry for
this second wrong information `:-P`
> I really think that the results are correct. The only discrepancy with
all the results in the literature is in the case of K5, where several
people seems to have copy-pasted the same result. This could very-well be
wrong everywhere.
Okayokay. Positive review then. What would you think of sending an email
to those guys to ask them what they think of it ? It's good to let them
know this is available somewhere, and can either let us fix a bug here or
let them fix a bug in their paper.
Thanks for this patch ! Sorry for the long review and errors `^^;`
Nathann
--
Ticket URL: <http://trac.sagemath.org/ticket/15662#comment:21>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica,
and MATLAB
--
You received this message because you are subscribed to the Google Groups
"sage-trac" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
To post to this group, send email to [email protected].
Visit this group at http://groups.google.com/group/sage-trac.
For more options, visit https://groups.google.com/groups/opt_out.
