#15567: Fix Alphabet and improvements to Family
-------------------------+-------------------------------------------------
Reporter: | Owner: sage-combinat
tscrim | Status: needs_work
Type: | Milestone: sage-6.1
defect | Resolution:
Priority: major | Merged in:
Component: | Reviewers:
combinatorics | Work issues:
Keywords: | Commit:
alphabet | 03b3045881fbff482768e4d3efee772c83d58da8
Authors: | Stopgaps:
Travis Scrimshaw |
Report Upstream: N/A |
Branch: |
public/15567 |
Dependencies: |
-------------------------+-------------------------------------------------
Comment (by tscrim):
Replying to [comment:15 ncohen]:
> I have absolutely no clue of what this function does. That's the
problem. Show the documentation above to anybody you meet, and ask him to
deduce what the function returns. If he gets it I am wrong, otherwise it
needs to be rewritten.
If the documentation isn't clear, I read the code. IMO this function is
not very complicated to understand from the code itself.
> Come on. It must be possible to write properly what the arguments
actually mean `O_o`
I wrote what they mean (at least, to me), but not how they are used
(together).
> Thank you very much. Knowing what "hidden" means actually help.
>
> Hey Travis, what do you think I am doing here ? Why would I come add
comments to this ticket just to make it more painful for you ?
> I honestly do not understand what "hidden" means in this context. No
way. Does it mean that the letters are ignored ? That they just aren't
displayed but that they are still stored somewhere ? Does this parameter
have any actual use or should it be removed ?
I'm sorry; I didn't realize that this was a language/definition issue
(please don't post a reply in French, I think I know more Mandarin than
French `:p`). I know you are trying to make Sage's doc more user friendly.
I still think that the example which demonstrates these arguments will do
much better than a long explanation in the `INPUT:` block. As I recall,
the hidden keys/functions are used in the root systems.
> That's what I want to find out. I have no idea what it does at the
moment.
>
> There are 4 commits with unclear commit messages, and these four commits
are as useful as none, as in the branch I uploaded. And I never had to
recompile anything, I do not understand why you bring this up.
Switch between branches which are not up to the latest development version
(something like `6.1.beta1`), and almost all of the cython files will be
rebuilt because some low-level `.pxi` or `.pxd` file is changed.
> How do they review stuff if each commit is meaningless ? `O_o`
The sum of the parts. The history is only there to see what changed where
and when and by whom.
--
Ticket URL: <http://trac.sagemath.org/ticket/15567#comment:16>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica,
and MATLAB
--
You received this message because you are subscribed to the Google Groups
"sage-trac" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
To post to this group, send email to [email protected].
Visit this group at http://groups.google.com/group/sage-trac.
For more options, visit https://groups.google.com/groups/opt_out.
