#15466: Remove deprecated code from combinat/
-------------------------------------+-------------------------------------
Reporter: ncohen | Owner:
Type: defect | Status: positive_review
Priority: major | Milestone: sage-6.1
Component: combinatorics | Resolution:
Keywords: | Merged in:
Authors: Nathann Cohen | Reviewers: Andrew Mathas
Report Upstream: N/A | Work issues:
Branch: | Commit:
u/tscrim/ticket/15466 | cd43d7b88cd56b54165a8d5c9b19a0e4ed796bb7
Dependencies: #15467 | Stopgaps:
-------------------------------------+-------------------------------------
Changes (by andrew.mathas):
* status: needs_review => positive_review
Comment:
I didn't understand why this patch should affect {{{cachefunc.pyx}}} but
the doc-tests causing the problems all call {{{number_of_partitions}}}.
Part of this patch removes depreciated code in {{{partition.py}}} and, in
particular, it changes the calling syntax by removing a depreciated
argument of {{{k=None}}}. This both explains the errors above and says
that the correct fix is simply to change the output of the doct-tests as
the patch does. Hence, positive review.
Andrew
--
Ticket URL: <http://trac.sagemath.org/ticket/15466#comment:11>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica,
and MATLAB
--
You received this message because you are subscribed to the Google Groups
"sage-trac" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
To post to this group, send email to [email protected].
Visit this group at http://groups.google.com/group/sage-trac.
For more options, visit https://groups.google.com/groups/opt_out.
