#5954: Added documentation/doctests for all quadratic form genus symbol routines
-------------------------+--------------------------------------------------
Reporter: jonhanke | Owner: tbd
Type: enhancement | Status: new
Priority: major | Milestone: sage-4.0.1
Component: algebra | Keywords: QuadraticForm
-------------------------+--------------------------------------------------
Comment(by tornaria):
Looks good to me. The renamings mentioned by mabshoff are:
- {{{signature_of_matrix}}} renamed to {{{signature_pair_of_matrix}}}
- {{{is_even}}} renamed to {{{is_even_matrix}}}
- {{{trace_diag}}} renamed to {{{trace_diag_mod_8}}}
- {{{is_trivial_symbol}}} removed
Of these the first three are internal, not exported in
{{{sage.quadratic_forms.all}}. The renaming aids to readability. The
fourth one was actually exported, but apparently it was not clear what it
does (the comment reads "Removed because it was unused and
undocumented!"). Jon may want to add a comment about it here.
Other than that, I will be giving positive review together with the whole
series of QF doctest patches summarized in #6040, since coverage goes up
to 100% and all doctest pass after a few trivial bugfixes.
Incidentally, this patch fixes the issue in #5837, so that one should be
closed as this patch gets merged.
--
Ticket URL: <http://trac.sagemath.org/sage_trac/ticket/5954#comment:3>
Sage <http://sagemath.org/>
Sage - Open Source Mathematical Software: Building the Car Instead of
Reinventing the Wheel
--~--~---------~--~----~------------~-------~--~----~
You received this message because you are subscribed to the Google Groups
"sage-trac" group.
To post to this group, send email to [email protected]
To unsubscribe from this group, send email to
[email protected]
For more options, visit this group at
http://groups.google.com/group/sage-trac?hl=en
-~----------~----~----~----~------~----~------~--~---
