#15683: Interval-posets of Tamari
-------------------------------------+-------------------------------------
Reporter: VivianePons | Owner:
Type: enhancement | Status: needs_review
Priority: major | Milestone: sage-6.2
Component: combinatorics | Resolution:
Keywords: combinat, Tamari, | Merged in:
binary trees, Dyck paths | Reviewers:
Authors: Viviane Pons | Work issues:
Report Upstream: N/A | Commit:
Branch: public/combinat | d8253699427e08f0942aa8094139130f04dd53ff
/interval-posets-15683 | Stopgaps:
Dependencies: |
-------------------------------------+-------------------------------------
Comment (by darij):
I haven't reviewed it, but just some notes:
- Yes, please don't import the new module into global namespace. This
seems like a case for lazy import, if not less (what about
`Posets.TamariIntervalPoset`?).
- I suspect `greater than ``self``` should be `greater or equal to
``self```.
- I want more doc and possibly more references. What is a Tamari interval?
(I am talking about intervals in the Tamari order, not about the general
"Tamari interval-posets" which you define nicely. I kind-of know the
answer in the case of trees, but I wouldn't be surprised if there are
nonstandard choices to make.)
- The way you are using "vertex parent", it seems that "vertex ancestor"
would be more appropriate. Is this standard notation?
- "contained into" should be "contained in". (There is a line break
between "contained" and "into" where this error occurs, in case you want
to find/replace.)
- `t \leq t2` should be `t \leq t_2` in LaTeX mode.
- Is it necessary to define a method called `cardinality` which computes
something different from the cardinality of the poset? I would call it
something like `interval_cardinality` instead...
- Please don't be shy and link to the arXiv number of your paper:
{{{
:arxiv:`1212.0751v1`
}}}
As you see I'm nitpicking, and the patch doesn't seem to have serious
issues from a quick glance at it. If you want me to review it, I can do
so, just let me know.
--
Ticket URL: <http://trac.sagemath.org/ticket/15683#comment:11>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica,
and MATLAB
--
You received this message because you are subscribed to the Google Groups
"sage-trac" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
To post to this group, send email to [email protected].
Visit this group at http://groups.google.com/group/sage-trac.
For more options, visit https://groups.google.com/groups/opt_out.
