#15810: Immutable directed graphs should know that they are directed
-------------------------------------+-------------------------------------
       Reporter:  SimonKing          |        Owner:
           Type:  defect             |       Status:  needs_review
       Priority:  major              |    Milestone:  sage-6.2
      Component:  graph theory       |   Resolution:
       Keywords:  immutable          |    Merged in:
  directed graph                     |    Reviewers:
        Authors:  Simon King         |  Work issues:
Report Upstream:  N/A                |       Commit:
         Branch:  public/15810       |  d6ca86c1d6984bc7a468b80905ddec01323cc9b6
   Dependencies:  #15623             |     Stopgaps:
-------------------------------------+-------------------------------------

Comment (by SimonKing):

 Could you elaborate why you ''remove'' one line in the following chunks,
 rather than replace `.directed` by `._directed`?
 {{{
 #!diff
 diff --git a/src/sage/graphs/digraph.py b/src/sage/graphs/digraph.py
 index f869bb0..d95e96e 100644
 --- a/src/sage/graphs/digraph.py
 +++ b/src/sage/graphs/digraph.py
 @@ -919,7 +919,6 @@ class DiGraph(GenericGraph):
                  self._weighted = weighted
                  self.allow_loops(loops, check=False)
                  self.allow_multiple_edges(multiedges, check=False)
 -            self._backend.directed = True
          else:
              raise NotImplementedError("Supported implementations:
 networkx, c_graph.")

 diff --git a/src/sage/graphs/graph.py b/src/sage/graphs/graph.py
 index a3f1dcd..4d15305 100644
 --- a/src/sage/graphs/graph.py
 +++ b/src/sage/graphs/graph.py
 @@ -1542,7 +1542,6 @@ class Graph(GenericGraph):
                  self._weighted = weighted
                  self.allow_loops(loops, check=False)
                  self.allow_multiple_edges(multiedges, check=False)
 -            self._backend.directed = False
          else:
              raise NotImplementedError("Supported implementations:
 networkx, c_graph.")
 }}}

--
Ticket URL: <http://trac.sagemath.org/ticket/15810#comment:38>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica, 
and MATLAB

-- 
You received this message because you are subscribed to the Google Groups 
"sage-trac" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to [email protected].
To post to this group, send email to [email protected].
Visit this group at http://groups.google.com/group/sage-trac.
For more options, visit https://groups.google.com/groups/opt_out.

Reply via email to