#15835: Smith Normal Form Integers Mod 2 TypeError: submatrix() takes exactly 4
positional arguments(2 given)
-------------------------------------+-------------------------------------
Reporter: andrewsilver | Owner:
Type: defect | Status: needs_review
Priority: minor | Milestone: sage-6.2
Component: linear algebra | Resolution:
Keywords: | Merged in:
Authors: | Reviewers:
Report Upstream: N/A | Work issues:
Branch: | Commit:
u/andrewsilver/ticket/15835 | f636d4b3e4d006437edd0da6295ce8d516db6247
Dependencies: | Stopgaps:
-------------------------------------+-------------------------------------
Comment (by fwclarke):
A rather simpler alternative is to delete the `submatrix` methods for the
`Matrix_mod2_dense` and `Matrix_mod2e_dense` classes (in the files
`sage/matrix/matrix_mod2_dense.pyx` and
`sage/matrix/matrix_mod2e_dense.pyx`, respectively). This would mean that
all matrices would use the same `submatrix` method. It's completely
unclear to me what the extra methods add, and their different syntax has
caused the present problem.
I tried commenting them out. It solved the problem addressed in this
ticket, and all doctests still passed. A quick check suggested that there
was no discernible change in timings.
--
Ticket URL: <http://trac.sagemath.org/ticket/15835#comment:6>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica,
and MATLAB
--
You received this message because you are subscribed to the Google Groups
"sage-trac" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
To post to this group, send email to [email protected].
Visit this group at http://groups.google.com/group/sage-trac.
For more options, visit https://groups.google.com/groups/opt_out.
