#12630: Add representations of quivers and quiver algebras to sage
-------------------------------------+-------------------------------------
Reporter: JStarx | Owner: AlexGhitza
Type: enhancement | Status: needs_review
Priority: major | Milestone: sage-6.2
Component: algebra | Resolution:
Keywords: algebra, quiver, | Merged in:
module, days49 | Reviewers: Simon King
Authors: Jim Stark, Simon | Work issues:
King, Mathieu Guay-Paquet, Aladin | Commit:
Virmaux | c5dd56af126669e380f5a9fbb1680447123d22cc
Report Upstream: N/A | Stopgaps:
Branch: |
public/combinat/quivers |
Dependencies: #12412, #12413, |
#14806, #15491, #15623, #15810 |
-------------------------------------+-------------------------------------
Comment (by nthiery):
+1 on the recent changes (making the elements immutable; making
set_element private, having a real hash function, ...)!
Just a random suggestions / questions:
- Maybe {{{QuiverRepElement}}} could inherit from {{{ElementWrapper}}}?
That would give it e.g. the hash for free.
- Is speed critical enough to motivate inheriting from ModuleElement?
- is there a reason to use {{{UniqueFactory}}} rather than
{{{UniqueRepresentation}}}?
- _iadd_ and _isub_ change the element in place and therefore break
immutability.
Are those methods really necessary?
- In this file: vaector -> vector
I am done with my teaching, and will have some time starting from March
1st. If the review is not finished by then, let me know which piece need
review and I'll work on it.
Cheers,
Nicolas
--
Ticket URL: <http://trac.sagemath.org/ticket/12630#comment:244>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica,
and MATLAB
--
You received this message because you are subscribed to the Google Groups
"sage-trac" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
To post to this group, send email to [email protected].
Visit this group at http://groups.google.com/group/sage-trac.
For more options, visit https://groups.google.com/groups/opt_out.
