#15705: functions PowerSeries.ogf() and egf() named wrong
-------------------------------------+-------------------------------------
Reporter: rws | Owner: rws
Type: defect | Status: needs_work
Priority: major | Milestone: sage-6.2
Component: combinatorics | Resolution:
Keywords: series ogf | Merged in:
Authors: rws | Reviewers:
Report Upstream: N/A | Work issues:
Branch: | Commit:
u/rws/ticket/15705 | 4b79c254541220c8bb1877a314bf8287edc6f360
Dependencies: | Stopgaps:
-------------------------------------+-------------------------------------
Old description:
> The documentation states: ''Returns the ordinary generating function
> associated to self.'' But the function is a wrapper for the Pari function
> `serlaplace()` which converts to ordinary g.f. in the case of an
> exponential g.f.
>
> Example: `1+x+x^2+x^3+x^4+O(x^5)` is generated both by `1/(1-x)+O(x^5)`
> or itself, but:
> {{{
> sage: R.<x> = PowerSeriesRing(ZZ)
> sage: (1+x+x^2+x^3+x^4+O(x^5)).ogf()
> 1 + x + 2*x^2 + 6*x^3 + 24*x^4
> }}}
> which is clearly wrong given name and definition.
>
> So, I hope you agree it's necessary if I rename `ogf()` to `egf_to_ogf()`
> (or a better name), and adapt the docs.
New description:
The functions `PowerSeries.ogf()` and `egf()` are named wrong
The documentation states: ''Returns the ordinary generating function
associated to self.'' But the function is a wrapper for the Pari function
`serlaplace()` which actually converts to ordinary g.f. in the case of an
exponential g.f.
Example: `1+x+x^2+x^3+x^4+O(x^5)` is generated both by `1/(1-x)+O(x^5)` or
itself, but:
{{{
sage: R.<x> = PowerSeriesRing(ZZ)
sage: (1+x+x^2+x^3+x^4+O(x^5)).ogf()
1 + x + 2*x^2 + 6*x^3 + 24*x^4
}}}
which is clearly wrong given name and definition.
So, I hope you agree it's necessary if I rename `ogf()` to `egf_to_ogf()`
and `egf()` to `ogf_to_egf()` and adapt the docs.
--
Comment (by rws):
It appears that we would have to deprecate the old names first.
--
Ticket URL: <http://trac.sagemath.org/ticket/15705#comment:6>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica,
and MATLAB
--
You received this message because you are subscribed to the Google Groups
"sage-trac" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
To post to this group, send email to [email protected].
Visit this group at http://groups.google.com/group/sage-trac.
For more options, visit https://groups.google.com/groups/opt_out.
