#4120: New code for binary quadratic forms
-------------------------------------+-------------------------------------
Reporter: justin | Owner: justin
Type: enhancement | Status: needs_work
Priority: major | Milestone: sage-6.2
Component: quadratic forms | Resolution:
Keywords: | Merged in:
Authors: Justin Walker, | Reviewers: John Cremona
Jon Hanke, Gonzalo Tornaria, John | Work issues: more tests for
Cremona | is_reduced, doc of primitive_only
Report Upstream: N/A | Commit:
Branch: | 96c1a86e063e7a7512978c574ec40c84641b66d4
u/pbruin/4120-binary_quadratic_forms| Stopgaps:
Dependencies: |
-------------------------------------+-------------------------------------
Changes (by pbruin):
* work_issues: => more tests for is_reduced, doc of primitive_only
Old description:
> The code supporting binary quadratic forms, in
> quadratic_forms/binary_qf.py, is missing some functionality, and relies
> on Magma and Pari. The patch in this ticket provides the following
> changes:
> - tests for equivalence, normal, positive and negative definite,
> indefinite, primitive forms
> - normalize a form
> - action of matrix on a form
> - find content; factor indefinite forms
> In addition:
> - reduce() no longer calls Pari
> - some cleanup: is_reduced() is rewritten; polynomial() replaced with an
> instance variable (poly)
>
> Doctests are in place for the new code, so the file remains at 100%
> coverage.
New description:
The code supporting binary quadratic forms, in
quadratic_forms/binary_qf.py, is missing some functionality. The patch in
this ticket provides the following changes:
- better support for indefinite forms
- tests for equivalence, positive and negative definite, indefinite,
primitive forms
- action of matrix on a form
- find content
- is_reduced() is rewritten
- polynomial() now uses an instance variable (poly)
- some general cleaning up
Doctests are in place for the new code, so the file remains at 100%
coverage.
--
--
Ticket URL: <http://trac.sagemath.org/ticket/4120#comment:30>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica,
and MATLAB
--
You received this message because you are subscribed to the Google Groups
"sage-trac" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
To post to this group, send email to [email protected].
Visit this group at http://groups.google.com/group/sage-trac.
For more options, visit https://groups.google.com/groups/opt_out.
