#15864: Graph.is_distance_regular is awfully wrong
-------------------------+-------------------------------------------------
       Reporter:         |        Owner:
  ncohen                 |       Status:  needs_review
           Type:         |    Milestone:  sage-6.2
  defect                 |   Resolution:
       Priority:  major  |    Merged in:
      Component:  graph  |    Reviewers:
  theory                 |  Work issues:
       Keywords:         |       Commit:
        Authors:         |  20c5a2ad3ec2074eb2c89ca27622907a2e115557
  Nathann Cohen          |     Stopgaps:
Report Upstream:  N/A    |
         Branch:         |
  u/ncohen/15864         |
   Dependencies:         |
-------------------------+-------------------------------------------------

Comment (by dimpase):

 Replying to [comment:23 ncohen]:
 > The definitions are inconsistant since you changed it in your first
 commit :
 >
 >
 
http://git.sagemath.org/sage.git/commit/?h=20c5a2ad3ec2074eb2c89ca27622907a2e115557&id=e5a990dd8f2b0ff38dcee683e9d59182d2614eb1
 >
 > Could you fix that to make the doc and code consistent ?

 OK, I see, that's what happened: indeed, I changed docs (except the docs
 for the return value, just forgot these - that's why there was one more
 commit) in the first commit,
 as well as the order of the things returned in `return`.  For the sake of
 code readability it would be great to change the code too, indeed. Do you
 want me to do this, or you prefer to do this yourself?

--
Ticket URL: <http://trac.sagemath.org/ticket/15864#comment:24>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica, 
and MATLAB

-- 
You received this message because you are subscribed to the Google Groups 
"sage-trac" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to [email protected].
To post to this group, send email to [email protected].
Visit this group at http://groups.google.com/group/sage-trac.
For more options, visit https://groups.google.com/groups/opt_out.

Reply via email to