#15855: Clean up weierstrass_p
-------------------------------------+-------------------------------------
       Reporter:  jdemeyer           |        Owner:
           Type:  enhancement        |       Status:  positive_review
       Priority:  major              |    Milestone:  sage-6.2
      Component:  elliptic curves    |   Resolution:
       Keywords:                     |    Merged in:
        Authors:  Jeroen Demeyer     |    Reviewers:  Peter Bruin
Report Upstream:  N/A                |  Work issues:
         Branch:                     |       Commit:
  u/jdemeyer/ticket/15855            |  666714eb35225661954ce037892f40d866cc04c3
   Dependencies:                     |     Stopgaps:
-------------------------------------+-------------------------------------
Changes (by jdemeyer):

 * status:  needs_review => positive_review


Comment:

 Replying to [comment:16 pbruin]:
 > The last part of the new changelog entry in `ell_wp.py` is no longer
 accurate.  Besides that, positive review.
 Done.

 > (Maybe the additional change proposed in comment:9 isn't the best one;
 perhaps there are elliptic curves where more coefficients of the series
 are well defined, in which case a `NotImplementedError` is better than an
 algorithm-independent `ValueError`.)
 I have no idea, I don't know the mathematics well enough.

--
Ticket URL: <http://trac.sagemath.org/ticket/15855#comment:18>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica, 
and MATLAB

-- 
You received this message because you are subscribed to the Google Groups 
"sage-trac" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to [email protected].
To post to this group, send email to [email protected].
Visit this group at http://groups.google.com/group/sage-trac.
For more options, visit https://groups.google.com/groups/opt_out.

Reply via email to