#6041: [with spkg, needs work] update NetworkX to version 0.99
--------------------------+-------------------------------------------------
Reporter: mvngu | Owner: rlm
Type: enhancement | Status: new
Priority: major | Milestone: sage-4.0.1
Component: graph theory | Keywords:
--------------------------+-------------------------------------------------
Comment(by rlm):
Replying to [comment:5 mvngu]:
> Replying to [comment:4 rlm]:
> > Replying to [comment:3 mvngu]:
> Previously {{{XGraph}}} handle undirected graphs with or without
multiple edges, and {{{XDiGraph}}} handle directed graphs with or without
multiple edges. Now there are four graph classes instead of two, for
handling the different types of graphs.
Actually, there were also `Graph` and `DiGraph`, which did not have
labels...
> > > Here's a diff of the changes to
`sage/graphs/base/graph_backends.py`:
> >
> > Next time you could probably attach the diff to the ticket... :)
> No, the diff isn't meant to be committed in the future. It's there for
discussion and to explore ways to maintain compatibility with the existing
API in {{{graph_backends.py}}}.
You can still post diffs as attachments. It makes the discussion much
easier to follow when you're reading the ticket, and it keeps clutter
down. Just add the note "not to be applied" if you're worried...
> > > It looks like anything under {{{sage/graphs/}}} that uses
{{{sage/graphs/base/graph_backends.py}}} should be changed accordingly.
> >
> > Don't forget all of the rest of Sage! I think you'll find it much
easier to adapt the backend to behave exactly as before. Then, all the
other doctests should pass - that's what they're there for!
> OK, let me see what I can do.
It should be possible to get all of the doctests in Sage working by
changing only things which call `networkx` directly (i.e. things involving
`import networkx`), and the `NetworkXGraphBackend` class in
`graph_backends.py`. Keep in mind that there are several interchangeable
backends. In your diff, you were actually changing the signature of some
of the backend functions-- this is bad.
--
Ticket URL: <http://trac.sagemath.org/sage_trac/ticket/6041#comment:6>
Sage <http://sagemath.org/>
Sage - Open Source Mathematical Software: Building the Car Instead of
Reinventing the Wheel
--~--~---------~--~----~------------~-------~--~----~
You received this message because you are subscribed to the Google Groups
"sage-trac" group.
To post to this group, send email to [email protected]
To unsubscribe from this group, send email to
[email protected]
For more options, visit this group at
http://groups.google.com/group/sage-trac?hl=en
-~----------~----~----~----~------~----~------~--~---
