#15705: functions PowerSeries.ogf() and egf() named wrong
-------------------------+-------------------------------------------------
Reporter: rws | Owner: rws
Type: | Status: needs_review
defect | Milestone: sage-6.2
Priority: major | Resolution:
Component: | Merged in:
combinatorics | Reviewers: Nathann Cohen
Keywords: | Work issues:
series ogf | Commit:
Authors: Ralf | 813a8075202e9e6c70e83f4fafc0e7af7ef66d4b
Stephan | Stopgaps:
Report Upstream: N/A |
Branch: |
public/15705 |
Dependencies: |
-------------------------+-------------------------------------------------
Changes (by ncohen):
* commit: 4ae59bea6a7e7ab45b9839ee1cd05ff2f70b9317 =>
813a8075202e9e6c70e83f4fafc0e7af7ef66d4b
* branch: u/rws/ticket/15705 => public/15705
* reviewer: => Nathann Cohen
Comment:
Hmmmmm... at first I did not like the new names at all, and prefered
`.to_egf()` and `.to_ogf()`, but the way you did it will make it the
easiest to find for new users... Hmmmm.... !
I just added a small commit on top of yours to fix two things:
1) The `ogf=...` and `egf=...` had a wrong indentation level
2) The `deprecated_function_alias` function was not imported
All tests pass. If you agree with my changes you can set the ticket to
`positive_review`.
Nathann
----
New commits:
||[http://git.sagemath.org/sage.git/commit/?id=813a8075202e9e6c70e83f4fafc0e7af7ef66d4b
813a807]||{{{trac #15705: reviewer's patch}}}||
--
Ticket URL: <http://trac.sagemath.org/ticket/15705#comment:13>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica,
and MATLAB
--
You received this message because you are subscribed to the Google Groups
"sage-trac" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
To post to this group, send email to [email protected].
Visit this group at http://groups.google.com/group/sage-trac.
For more options, visit https://groups.google.com/d/optout.
