#16009: Compute rank of elliptic curve defined over relative number field
-------------------------------------+-------------------------------------
       Reporter:  mmasdeu            |        Owner:
           Type:  enhancement        |       Status:  needs_work
       Priority:  major              |    Milestone:  sage-6.2
      Component:  elliptic curves    |   Resolution:
       Keywords:  descent, rank,     |    Merged in:
  elliptic curve, relative number    |    Reviewers:  Peter Bruin
  field                              |  Work issues:
        Authors:  mmasdeu            |       Commit:
Report Upstream:  N/A                |  2085e0c096a1a18a15d8dbcdde06627749b90542
         Branch:                     |     Stopgaps:
  u/mmasdeu/gp_simon_relative        |
   Dependencies:                     |
-------------------------------------+-------------------------------------
Changes (by pbruin):

 * status:  needs_review => needs_work
 * reviewer:   => Peter Bruin


Comment:

 Looks good and passes all tests.  The new doctest does take a long time (4
 minutes), but that is probably hard to avoid.  Two comments:
 - use your real name for the "Authors" field
 - the documentation line starting with "An example with" should be
 indented
 After fixing those, feel free to set this to positive review.

--
Ticket URL: <http://trac.sagemath.org/ticket/16009#comment:2>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica, 
and MATLAB

-- 
You received this message because you are subscribed to the Google Groups 
"sage-trac" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to [email protected].
To post to this group, send email to [email protected].
Visit this group at http://groups.google.com/group/sage-trac.
For more options, visit https://groups.google.com/d/optout.

Reply via email to