#15272: Bruhat posets and Bruhat graphs for parabolic subgroups of finite Weyl
groups
-------------------------------------+-------------------------------------
       Reporter:  vittucek           |        Owner:
           Type:  enhancement        |       Status:  needs_review
       Priority:  major              |    Milestone:  sage-6.2
      Component:  combinatorics      |   Resolution:
       Keywords:                     |    Merged in:
        Authors:  Vít Tuček          |    Reviewers:
Report Upstream:  N/A                |  Work issues:
         Branch:                     |       Commit:
  u/vittucek/ticket/15272            |  b1e25e678525b169df881ef8312ecf30e64d3adf
   Dependencies:                     |     Stopgaps:
-------------------------------------+-------------------------------------
Changes (by vittucek):

 * commit:  1b1220d530e96cbfaf0927c539475327891e027d =>
     b1e25e678525b169df881ef8312ecf30e64d3adf


Comment:

 Replying to [comment:7 darij]:
 > There is a merge conflict with develop:
 > {{{
 >         x = x.coset_representative(index_set,side)
 >         y = y.coset_representative(index_set,side)
 >         g = self.bruhat_poset(index_set, crossed_nodes, side,
 facade=True).interval(x,y)
 >         ref = self.reflections()
 >         d = {}
 >         for x in g:
 > <<<<<<< HEAD
 >             d[x] = [y for y in g if x.length() < y.length() and
 x*y.inverse() in ref]
 > =======
 >             d[x] = {}
 >             for y in g:
 >                 if side == "right":
 >                     r = y*x.inverse()
 >                 else:
 >                     r = x.inverse()*y
 >                 if x.length() < y.length() and ref.has_key(r):
 >                     d[x][y] = r
 > >>>>>>> 92888b345acb3f6726c1d38ab16d4f1366fbb757
 >         return DiGraph(d)
 > }}}
 > I'm pushing a branch (warning: branch change!) in which I resolve this
 in favor of your patch's version (the longer one, with the "for y in g"
 loop and the dictionary rather than the list). If this is wrong, please
 let me know.
 > ----

 Thanks!  I've made the change you've requested (and moreover I've switched
 the order of tests to benefit from short-circuiting. I didn't know how to
 add the patch on top of your branch (insufficient permissions?) so I just
 went with what `sage -dev push` suggested. I hope that's fine.
 ----
 New commits:
 
||[http://git.sagemath.org/sage.git/commit/?id=b1e25e678525b169df881ef8312ecf30e64d3adf
 b1e25e6]||{{{Performance enhancement in bruhat_graph}}}||

--
Ticket URL: <http://trac.sagemath.org/ticket/15272#comment:12>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica, 
and MATLAB

-- 
You received this message because you are subscribed to the Google Groups 
"sage-trac" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to [email protected].
To post to this group, send email to [email protected].
Visit this group at http://groups.google.com/group/sage-trac.
For more options, visit https://groups.google.com/d/optout.

Reply via email to