#15956: WeakValueDictionary does not handle unhashable keys correctly
-------------------------------------+-------------------------------------
       Reporter:  saraedum           |        Owner:
           Type:  defect             |       Status:  needs_review
       Priority:  minor              |    Milestone:  sage-6.2
      Component:  misc               |   Resolution:
       Keywords:  hash               |    Merged in:
        Authors:  Julian, Nils       |    Reviewers:  Nils Bruin, ???
  Bruin                              |  Work issues:
Report Upstream:  N/A                |       Commit:
         Branch:                     |  109c161ca077a7d8fc6fc91fc1dce48f439234e6
  u/nbruin/ticket/15956              |     Stopgaps:
   Dependencies:                     |
-------------------------------------+-------------------------------------
Changes (by {'newvalue': u'Julian, Nils Bruin', 'oldvalue': ''}):

 * reviewer:   => Nils Bruin, ???
 * author:   => Julian, Nils Bruin


Comment:

 *PING* I'm happy with Julian's doctests. The current use of
 `PyDict_GetItemWithError` actually gives slightly better performance than
 we had before AND we get fully compliant error reporting. So I'd be happy
 with the current solution. If Julian can give my change a positive review,
 we can get this tiny, unimportant improvement merged. Please complete the
 reviewer field when you're done.

--
Ticket URL: <http://trac.sagemath.org/ticket/15956#comment:9>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica, 
and MATLAB

-- 
You received this message because you are subscribed to the Google Groups 
"sage-trac" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to [email protected].
To post to this group, send email to [email protected].
Visit this group at http://groups.google.com/group/sage-trac.
For more options, visit https://groups.google.com/d/optout.

Reply via email to