#16027: Implement q-dimension for classical and KR crystals
-------------------------------------+-------------------------------------
       Reporter:  tscrim             |        Owner:  sage-combinat
           Type:  enhancement        |       Status:  needs_review
       Priority:  major              |    Milestone:  sage-6.2
      Component:  combinatorics      |   Resolution:
       Keywords:  q-analogs, Q       |    Merged in:
  systems                            |    Reviewers:  Ben Salisbury
        Authors:  Travis Scrimshaw   |  Work issues:
Report Upstream:  N/A                |       Commit:
         Branch:  u/tscrim/q_dims    |  96822d0592325d3e84db41ba716a35e89683fe1e
   Dependencies:                     |     Stopgaps:
-------------------------------------+-------------------------------------
Changes (by bsalisbury1):

 * reviewer:   => Ben Salisbury


Comment:

 Failed doctests:

 {{{
 sage -t --long src/sage/combinat/crystals/kirillov_reshetikhin.py
 **********************************************************************
 File "src/sage/combinat/crystals/kirillov_reshetikhin.py", line 641, in
 
sage.combinat.crystals.kirillov_reshetikhin.KirillovReshetikhinGenericCrystal.q_dimension
 Failed example:
     KRC.q_dimension()
 Expected:
     q^4 + q^3 + 2*q^2 + q + 1
 Got:
     0
 **********************************************************************
 File "src/sage/combinat/crystals/kirillov_reshetikhin.py", line 644, in
 
sage.combinat.crystals.kirillov_reshetikhin.KirillovReshetikhinGenericCrystal.q_dimension
 Failed example:
     KRC.q_dimension()
 Expected:
     q^10 + q^9 + 3*q^8 + 3*q^7 + 4*q^6 + 4*q^5 + 4*q^4 + 3*q^3 + 3*q^2 + q
 + 2
 Got:
     0
 **********************************************************************
 1 item had failures:
    2 of   5 in
 
sage.combinat.crystals.kirillov_reshetikhin.KirillovReshetikhinGenericCrystal.q_dimension
     [671 tests, 2 failures, 37.43 s]
 }}}

 {{{
 ----------------------------------------------------------------------
 sage -t --long src/sage/combinat/crystals/kirillov_reshetikhin.py  # 2
 doctests failed
 ----------------------------------------------------------------------
 Total time for all tests: 1661.3 seconds
     cpu time: 11465.3 seconds
     cumulative wall time: 12898.9 seconds
 }}}

 There are some documentation errors:
  - ''weight space \mu'' should be either ''\mu-weight space'' or ''weight
 space of weight \mu''
  - There is a B(\Lambda) where there should be a B(\lambda)
  - Last sentence before input: ''Mor more...'' should be ''For more...''
  - The fact that the reference is the second edition of Kac should be in
 the reference and not in the paragraph

--
Ticket URL: <http://trac.sagemath.org/ticket/16027#comment:8>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica, 
and MATLAB

-- 
You received this message because you are subscribed to the Google Groups 
"sage-trac" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to [email protected].
To post to this group, send email to [email protected].
Visit this group at http://groups.google.com/group/sage-trac.
For more options, visit https://groups.google.com/d/optout.

Reply via email to